Run the community build CI with the correct sbt wrapper #6187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.drone.yml
Outdated
| @@ -41,7 +41,7 @@ pipeline: | |||
| - cp -R . /tmp/3/ && cd /tmp/3/ | |||
| - git submodule update --init --recursive --jobs 7 | |||
| - export PATH=/tmp/4/project/scripts:$PATH | |||
There was a problem hiding this comment.
I thought this export would be enough for drone to pick ./project/scripts/sbt over the default.
There was a problem hiding this comment.
Yeah I don't know why that doesn't work.
There was a problem hiding this comment.
Ah, it's the wrong /tmp folder
In particular, this avoids situations where the JVM goes into interpreter-only mode because CodeCache is full.
smarter
force-pushed
the
community-build-cmd
branch
from
f933576 to
733f84d
Compare
It messes with our CI.
smarter
force-pushed
the
community-build-cmd
branch
3 times, most recently
from
6ef431b to
2730c9a
Compare
- It didn't work because it looked into /tmp/4/ instead of /tmp/3/ - Fixing that doesn't help, because project/scripts/sbt is not meant to be in the PATH: the script will try to run `sbt` to find the real sbt launcher, so if it is itself in the PATH we end up with an infinite loop.
smarter
force-pushed
the
community-build-cmd
branch
from
2730c9a to
17e78ad
Compare
OlivierBlanvillain
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this avoids situations where the JVM goes into
interpreter-only mode because CodeCache is full.