Skip to content

sbt-dotty: Don't break scaladoc in non-Dotty projects #6164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

smarter
Copy link
Member

@smarter smarter commented Mar 25, 2019

No description provided.

@fkowal
Copy link

fkowal commented Mar 25, 2019

does -from-tasty / docSettings
https://github.com/lampepfl/dotty/blob/master/sbt-dotty/src/dotty/tools/sbtplugin/DottyPlugin.scala#L335
make sense in pre dotty setup?

@smarter
Copy link
Member Author

smarter commented Mar 25, 2019

No that's also broken, will update the PR.

Also fix `test:doc` for Dotty projects: we were only passing `-project`
to dottydoc for `compile:doc`.

Dottydoc is still probably not working correctly in user projects but I'll
let whoever takes over its maintainership handle that.
Copy link
Contributor

@OlivierBlanvillain OlivierBlanvillain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarter smarter merged commit d249926 into scala:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants