Package dotty before running partest. #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,8 +118,8 @@ object DottyBuild extends Build { | |||
|
|
|||
| ("-DpartestParentID=" + pid) :: tuning ::: agentOptions ::: travis_build ::: fullpath | |||
| } | |||
| ) ++ addCommandAlias("partest", ";test:compile;lockPartestFile;test:test;runPartestRunner") ++ | |||
| addCommandAlias("partest-only", ";test:compile;lockPartestFile;test:test-only dotc.tests;runPartestRunner") | |||
| ) ++ addCommandAlias("partest", ";test:package;lockPartestFile;test:test;runPartestRunner") ++ | |||
There was a problem hiding this comment.
@DarkDimius you need compile:package, test:package produces dotty_2.11-0.1-SNAPSHOT-tests.jar instead of dotty_2.11-0.1-SNAPSHOT.jar.
To make sure that artifact is the same.
DarkDimius
force-pushed
the
partest-package
branch
from
532ccdf to
e693e66
Compare
|
@vsalvis, addressed your comments. |
|
LGTM. |
DarkDimius
added a commit
that referenced
this pull request
May 28, 2015
Package dotty before running partest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure that artifact is the same.
@vsalvis please review