-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Preserve tvar bounds that represent kinds #6156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,4 +23,4 @@ i4006c.scala | |
|
||
# Not sure what's wring here | ||
i4203.scala | ||
t6278-synth-def.scala | ||
t6278-synth-def.scala |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
import scala.compiletime._ | ||
|
||
object Test1 { | ||
type Foo[F[_]] | ||
type Bar[T] = T match { | ||
case Foo[f] => f[Int] | ||
} | ||
|
||
val li: Bar[Foo[List]] = List(1, 2, 3) | ||
} | ||
|
||
object Test2 { | ||
inline def summon[T] = implicit match { | ||
case t: T => t | ||
} | ||
|
||
class Foo[F[_]] | ||
|
||
inline def bar[T] = inline erasedValue[T] match { | ||
case _: Foo[f] => summon[f[Int]] | ||
} | ||
|
||
implicit val li: List[Int] = List(1, 2, 3) | ||
val lii = bar[Foo[List]] | ||
} | ||
|
||
object Test3 { | ||
inline def summon[T] = implicit match { | ||
case t: T => t | ||
} | ||
|
||
type K1Top = [t] => Any | ||
|
||
class Foo[F <: K1Top] | ||
|
||
inline def bar[T] = inline erasedValue[T] match { | ||
case _: Foo[f] => summon[f[Int]] | ||
} | ||
|
||
implicit val li: List[Int] = List(1, 2, 3) | ||
val lii = bar[Foo[List]] | ||
} | ||
|
||
object Test4 { | ||
inline def summon[T] = implicit match { | ||
case t: T => t | ||
} | ||
|
||
class Foo[F[t] >: List[t]] | ||
|
||
inline def bar[T] = inline erasedValue[T] match { | ||
case _: Foo[f] => summon[f[Int]] | ||
} | ||
|
||
implicit val li: List[Int] = List(1, 2, 3) | ||
val lii = bar[Foo[List]] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks a bit suspicious (we should already record the info as bounds in
newPatternBoundSymbol
), so I checked why does it make a difference. It seems that when adding bounds toConstraint
, it checks whether they fit in theTypeParamRef
s original bounds. This turns out to actually fail when dealing with HK types.This'll do for now, but I'd like to touch up this code in the future - in general when inserting a symbol into GADTMap, we probably should just use the initial bounds as the fake
TypeParamRef
s bounds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then can you open an issue and add a TODO in the code that points to the issue so we can keep track of this ?