Skip to content

Add inlined invariant assertions and fixes #6122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Mar 19, 2019

Add Ycheck assertions that check that all trees have the expected source. Trees inside the expansion of an Inlined tree have the source of the definition of the inlined call. If the call is empty the source is reset to the source in the outer Inlined.

At the same time fix all inconsistencies found by the new assertions.

Future PR:

  • Add Inlined(Empty, ...) around inlined types
  • Check Inlined inside macro-expanded code.

@nicolasstucki nicolasstucki self-assigned this Mar 19, 2019
@nicolasstucki nicolasstucki force-pushed the add-inlined-invariant-assertions branch 4 times, most recently from 9779aed to 7363503 Compare March 21, 2019 14:47
@nicolasstucki nicolasstucki marked this pull request as ready for review March 22, 2019 09:09
@nicolasstucki nicolasstucki removed their assignment Mar 22, 2019
@nicolasstucki nicolasstucki requested a review from odersky March 22, 2019 09:10
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@odersky odersky assigned nicolasstucki and unassigned odersky Mar 22, 2019
@nicolasstucki nicolasstucki force-pushed the add-inlined-invariant-assertions branch from 126e106 to 716e935 Compare March 22, 2019 16:52
@nicolasstucki nicolasstucki force-pushed the add-inlined-invariant-assertions branch from 716e935 to 69cf220 Compare March 22, 2019 16:56
@nicolasstucki nicolasstucki merged commit acb2ceb into scala:master Mar 22, 2019
@ghost ghost removed the stat:needs review label Mar 22, 2019
@nicolasstucki nicolasstucki deleted the add-inlined-invariant-assertions branch March 22, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants