Skip to content

Fix #6015: Transform inner missing trees #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

Fix #6015: Transform inner missing trees #6121

merged 1 commit into from
Mar 20, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Mar 19, 2019 •
edited
Loading

These cases explicitly create the untpd trees to ensure the trees have the correct source. We were just not transforming the children of those cases.

@nicolasstucki nicolasstucki marked this pull request as ready for review March 19, 2019 18:52
liufengyun
liufengyun approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit db8a1eb into scala:master Mar 20, 2019
@ghost ghost removed the stat:needs review label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun