Print missing package prefixes #6113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-missing-package-prefix
branch
from
538b49c to
24e11f2
Compare
liufengyun
reviewed
Mar 19, 2019
| val packagePath = sym.owner.fullName.stripPrefix("<root>").stripPrefix("<empty>").stripPrefix(".") | ||
| if (packagePath != "") | ||
| this += packagePath += "." | ||
| } |
There was a problem hiding this comment.
I'm wondering inside the if, what is the value of prefix at runtime?
There was a problem hiding this comment.
It is a Types.EmptyPrefix() as the pattern matching indicates.
There was a problem hiding this comment.
If that is the case, it seems to me the type is ill-formed, the prefix is wrong -- or I misunderstood the invariant for TermRef. We can get this in to unblock other issues, but it would be nice to clarify the invariant about TermRef. /cc: @odersky .
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the missing prefix makes the recompilation test complain because of an unknown package.