Skip to content

Cancel quotes/splice early #6093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

nicolasstucki
Copy link
Contributor

This allows us to warn about unnecessary quotes and splices rather than just cancelling them.

@nicolasstucki nicolasstucki self-assigned this Mar 14, 2019
This allows us to warn about unnecessary quotes and splices rather than just cancelling them.
@nicolasstucki nicolasstucki force-pushed the cancel-quote-splice-early branch from 1d7dc31 to d06cf48 Compare March 14, 2019 17:05
@nicolasstucki nicolasstucki marked this pull request as ready for review March 14, 2019 17:14
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit d06beff into scala:master Mar 14, 2019
@ghost ghost removed the stat:needs review label Mar 14, 2019
@nicolasstucki nicolasstucki deleted the cancel-quote-splice-early branch March 14, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants