Refine import implied rules to smooth migration
#6041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
9eb60f1 defines new rules for |
odersky
force-pushed
the
fix-import-implied
branch
from
569087b to
f510690
Compare
|
I moved i3430.check to pending because it made the test flakey. We could invest effort in a more robust test, but since the thing we are testing (implicit resolution disambiguation rules) is also in flux, it does not seem worth it at this point. Let's get back to it, when the new implicit resolution disambiguation rules have been fixed. |
|
Best reviewed by commit |
An import implied will also import old-style implicits, so the name is not correct anymore.
`import implied` now also imports old-style implicits. Missing implicits errors now report if an implied instance could have been imported if a regular import is changed to an import implied.
A cyclic instantiation was observed for neg/byname-implicits-11 when doing
an implicit search for a hidden implicits addendum.
It arose from a subtype check
Foo[Foo[T]] <: Foo[T]
where `Foo` is nonvariant and T is an instantiatable TypeParamRef.
odersky
force-pushed
the
fix-import-implied
branch
from
6216e1f to
3a19b43
Compare
smarter
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.