Skip to content

Avoid Context#clone #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Avoid Context#clone #6029

merged 2 commits into from
Mar 8, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Mar 6, 2019

Creating a context with a regular allocation is clearer.

Let's find out whether it is more efficient or not.

@odersky
Copy link
Contributor Author

odersky commented Mar 6, 2019

test performance please

@dottybot
Copy link
Member

dottybot commented Mar 6, 2019

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

dottybot commented Mar 6, 2019

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/6029/ to see the changes.

Benchmarks is based on merging with master (5f5b5b0)

@odersky
Copy link
Contributor Author

odersky commented Mar 7, 2019

test performance please

@dottybot
Copy link
Member

dottybot commented Mar 7, 2019

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

dottybot commented Mar 7, 2019

performance test failed:

Please check http://lamppc37.epfl.ch:8000/pull-6029-03-07-16.21.out for more information

@odersky odersky force-pushed the try-optimize-ctx branch from 13c4e2c to 02ff67a Compare March 7, 2019 16:17
@odersky
Copy link
Contributor Author

odersky commented Mar 7, 2019

test performance please

@dottybot
Copy link
Member

dottybot commented Mar 7, 2019

performance test scheduled: 2 job(s) in queue, 1 running.

@dottybot
Copy link
Member

dottybot commented Mar 7, 2019

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/6029/ to see the changes.

Benchmarks is based on merging with master (7d30a83)

@odersky
Copy link
Contributor Author

odersky commented Mar 8, 2019

We are in the noise wrt efficiency. I tested twice, the first time stdlib made a jump up, and the second time an equally large jump down. The other tests are more or less flat.

But clarity is a clear win, so I am going to merge this.

@odersky odersky merged commit 6571053 into scala:master Mar 8, 2019
@liufengyun liufengyun deleted the try-optimize-ctx branch March 8, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants