Skip to content

Fix #5015: disallow empty enum definition #6002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Fix #5015: disallow empty enum definition #6002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd5ace
Fix #5015: disallow empty enum definition
liufengyun Mar 1, 2019
7edf491
Fix CI
liufengyun Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions compiler/src/dotty/tools/dotc/parsing/Parsers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2556,6 +2556,11 @@ object Parsers {
val clsName = modName.toTypeName
val constr = classConstr()
val templ = templateOpt(constr, isEnum = true)
templ match {
case Template(_, _, _, List(EmptyTree)) =>
syntaxError("enum body should not be empty.", start)
case _ =>
}
finalizeDef(TypeDef(clsName, templ), addMod(mods, enumMod), start)
}

Expand Down
2 changes: 1 addition & 1 deletion compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class ErrorMessagesTests extends ErrorMessagesTest {
@Test def caseClassExtendsEnum =
checkMessagesAfter(RefChecks.name) {
"""
|enum Foo {}
|enum Foo { case A, B }
|case class Bar() extends Foo
""".stripMargin
}
Expand Down
1 change: 1 addition & 0 deletions tests/neg/i5015.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
enum A extends AnyRef { } // error