Fix #5954: Do not check prefix for non locally defined types #5961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Feb 21, 2019
|
|
||
| def impl2(a: MatcherFactory1)(self: Expr[a.AndNotWord]) = | ||
| '{ ~self } // error: access to value a from wrong staging level | ||
| } |
There was a problem hiding this comment.
I'm wondering how we can use a properly in such context? We need to have some principles to deal with terms in types.
There was a problem hiding this comment.
Maybe we could encode with something like
def impl2[T: Type](a: MatcherFactory1)(self: Expr[T])(implicit ev: T =:= a.AndNotWord) = ...
nicolasstucki
force-pushed
the
fix-#5954
branch
from
1cb7555 to
90f4d5b
Compare
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.