Skip to content

Make dotty use scala-infra for CI. #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2015
Merged

Conversation

DarkDimius
Copy link
Contributor

@adriaanm Thanks for huge help in getting this working 👍

@@ -0,0 +1,6 @@
baseDir=${WORKSPACE-`pwd`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these scripts will need #!/bin/bash -e to ensure the job fails.

@adriaanm
Copy link
Contributor

/rebuild

. $scriptsDir/common

update scala scala
sbt -Ddotty.travis.build=yes update compile test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-no-colors will avoid ugly ANSI codes in the output.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I've just seen scala/scala-jenkins-infra#57.

Allows sbts not to lock on the same ivy cache.
@DarkDimius DarkDimius mentioned this pull request May 20, 2015
@DarkDimius
Copy link
Contributor Author

All the builds will fail until commits from this branch get in.
@odersky you need to update your setup to be in sync with b671424, unfortunatelly we cannot use cd .. in CI anymore, so scala/scala went to a subfolder.

@DarkDimius DarkDimius mentioned this pull request May 20, 2015
@DarkDimius
Copy link
Contributor Author

@odersky please review and merge it to unblock other PRs

@retronym
Copy link
Member

@DarkDimius Not sure if you say my comment above, but I don't think you are correctly propagating the exit codes of the sbt process in your scripts.

I think these scripts will need #!/bin/bash -e to ensure the job fails.

@DarkDimius
Copy link
Contributor Author

@retronym I can add -e, but can you explain why current script is incorrect?
While integrating this PR there were moments when partest failed, and failure was propagated.

odersky added a commit that referenced this pull request May 20, 2015
Make dotty use scala-infra for CI.
@odersky odersky merged commit 4bac1a5 into scala:master May 20, 2015
@adriaanm
Copy link
Contributor

The -e option matters when you have multiple steps. Currently, only the last one will influence the exit code, so intermediate ones could fail and you won't be notified.

@DarkDimius
Copy link
Contributor Author

@adriaanm thanks for explaining!

@allanrenucci allanrenucci deleted the scala-infra branch December 14, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants