Skip to content

Fix #4539: Add missing '[ in canStartExpressionTokens #5815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2019
Merged

Fix #4539: Add missing '[ in canStartExpressionTokens #5815

merged 1 commit into from
Jan 30, 2019

Conversation

nicolasstucki
Copy link
Contributor

Previously '[ was not always handled as the start of an expression. Note that '[T] is an expression (not a type).

@ghost ghost assigned nicolasstucki Jan 29, 2019
@ghost ghost added the review label Jan 29, 2019
biboudis
biboudis approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@biboudis biboudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@biboudis biboudis merged commit f9dde9a into scala:master Jan 30, 2019
@ghost ghost removed the review label Jan 30, 2019
@biboudis biboudis deleted the fix-#4539 branch January 30, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biboudis biboudis biboudis approved these changes

Assignees

@biboudis biboudis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @biboudis