Skip to content

Fix #4184: Add regression test #5759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki added stat:needs review fasttrack Simple fix. Reviewer should merge or apply additional changes directly. labels Jan 21, 2019
@Blaisorblade
Copy link
Contributor

Not quite; #4184 was about Eq's error, but that particular instance disappeared. We can add that test if there's another reason, but for #4184 a better test might be:

scala> object foo { class Foo }
// defined object foo

scala> object bar { class Foo }
// defined object bar

scala> implicit def eqFoo: Eq[foo.Foo, foo.Foo] = Eq
def eqFoo: Eq[foo.Foo, foo.Foo]

scala> object Bar { new foo.Foo == new bar.Foo }
1 |object Bar { new foo.Foo == new bar.Foo }
  |                 ^^^^^^^^^^^^^^^^^^^^^^
  |      Values of types foo.Foo and bar.Foo cannot be compared with == or !=

Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@nicolasstucki
Copy link
Contributor Author

@Blaisorblade this PR needs a new review

@Blaisorblade Blaisorblade merged commit 0660c3e into scala:master Jan 21, 2019
@Blaisorblade Blaisorblade deleted the fix-#4184 branch January 21, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fasttrack Simple fix. Reviewer should merge or apply additional changes directly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants