Sort completions result in TabcompleteTests #5752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make the test deterministic.
odersky
reviewed
Jan 19, 2019
smarter
reviewed
Jan 19, 2019
| @@ -8,7 +8,7 @@ class TabcompleteTests extends ReplTest { | |||
|
|
|||
| /** Returns the `(<instance completions>, <companion completions>)`*/ | |||
| private[this] def tabComplete(src: String)(implicit state: State): List[String] = | |||
| completions(src.length, src, state).map(_.value) | |||
| completions(src.length, src, state).map(_.value).sorted | |||
There was a problem hiding this comment.
I think we might as well make completions return a sorted result.
There was a problem hiding this comment.
JLine has its own mechanism to sort completions. So it doesn't matter if you sort the completion result in the first place
smarter
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the test deterministic.