Skip to content

Reduce some allocations #5748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 19, 2019
Merged

Reduce some allocations #5748

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f618606
Add closure count instrumentation
odersky Jan 16, 2019
e8b9503
Also allow to count allocations in instrumentation
odersky Jan 17, 2019
e67ac03
Eliminate a hot closure in Reporter
odersky Jan 16, 2019
85a9257
Eliminate a hot closure in ConstFold by inlining
odersky Jan 16, 2019
218a673
Optimization: Make Reporter#unreportedWarnings an immutable map
odersky Jan 16, 2019
d820034
Optimization: Eliminate closures in PositionPickler#traverse
odersky Jan 16, 2019
73c0d3c
Optimization: Eliminate a hot closure in Implicits
odersky Jan 16, 2019
ae40761
Optimization: Don't result of addrOfTree in Some
odersky Jan 16, 2019
9d436ea
Optimization: Specialize tpes
odersky Jan 16, 2019
ee5d680
Optimize containsPhase
odersky Jan 16, 2019
f6b4559
Optimization: Avoid a closure in computeBaseData
odersky Jan 17, 2019
e46529f
Optimization: Avoid hot lazy vals in adaptNoArgs
odersky Jan 17, 2019
be65f09
Optimization: reduce creations of FlagConjunction
odersky Jan 17, 2019
7034d91
Statistics reporting: aggregate keys with common prefix
odersky Jan 17, 2019
8175d6a
Optimization: Specialize ==, != on value classes
odersky Jan 17, 2019
7dceba3
Eliminate some hot allocations
odersky Jan 17, 2019
b81b3b9
Record stats of SimpleIdentityMap sizes >= 4
odersky Jan 18, 2019
b3698d0
Update compiler/src/dotty/tools/dotc/typer/Typer.scala
smarter Jan 19, 2019
2ee9994
Update compiler/src/dotty/tools/dotc/typer/Typer.scala
smarter Jan 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion compiler/src/dotty/tools/dotc/ast/Positioned.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,12 @@ abstract class Positioned(implicit @constructorOnly src: SourceFile) extends Pro
else {
val newpd: this.type =
if (mySpan.isSynthetic) {
if (!mySpan.exists && span.exists)
if (!mySpan.exists && span.exists) {
envelope(source, span.startPos) // fill in children spans
() // Note: the `()` is there to prevent some inefficient code from being generated.
// Without it we get an allocation of a span here since the result type of the `if`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this changes whether an allocation happens or not but it does make the code more efficient, I've opened an issue to track this that you could refer to in this comment: #5750

// is `Any`, the lub of `Span` and `Unit`.
}
this
}
else cloneIn(source)
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/core/Names.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ object Names {
*/
def termName(cs: Array[Char], offset: Int, len: Int): SimpleName = synchronized {
util.Stats.record("termName")
val h = hashValue(cs, offset, len) & (table.size - 1)
val h = hashValue(cs, offset, len) & (table.length - 1)

/** Make sure the capacity of the character array is at least `n` */
def ensureCapacity(n: Int) =
Expand Down