Skip to content

Decompiler: empty parens, type variance #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2019
Merged

Decompiler: empty parens, type variance #5729

merged 4 commits into from
Jan 30, 2019

Conversation

tuvior
Copy link

@tuvior tuvior commented Jan 16, 2019

  • mark types as covariant + / contraviariant -
  • omit unnecessary empty parenthesis when listing type inheritances (extends with)

@nicolasstucki nicolasstucki self-requested a review January 16, 2019 16:58
@nicolasstucki
Copy link
Contributor

This PR will need to be rebased. Also, the following tests failed the testFromTasty tests

tests/run/simpleClass
tests/run/valueclasses-pavlov
tests/run/t4300
tests/run/t889
tests/run/virtpatmat_alts
tests/run/literals
tests/run/simpleClass
tests/run/valueclasses-pavlov
tests/run/t4300
tests/run/t889
tests/run/virtpatmat_alts
tests/run/literals

@nicolasstucki nicolasstucki self-assigned this Jan 16, 2019
@tuvior
Copy link
Author

tuvior commented Jan 20, 2019

Ah, I did check wheter the run part of tests also had .decompiled expected outputs, I'll rebase and update the outputs.

@nicolasstucki nicolasstucki force-pushed the decompiler-adjustments branch from 6b1ac99 to fdf8139 Compare January 29, 2019 10:29
@ghost ghost added the review label Jan 29, 2019
@nicolasstucki
Copy link
Contributor

LGTM. I rebased and fixed some release conflicts.

@nicolasstucki
Copy link
Contributor

@liufengyun could you review my additions?

liufengyun
liufengyun approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

liufengyun
liufengyun reviewed Jan 29, 2019
View reviewed changes
@nicolasstucki nicolasstucki merged commit 3283701 into scala:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@liufengyun liufengyun

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuvior @nicolasstucki @liufengyun @biboudis