Fix #4364: Try SAM type when no candidates are found #5717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Jan 15, 2019
adriaanm
approved these changes
Jan 15, 2019
| @@ -3,7 +3,7 @@ import collection._ | |||
| object Test { | |||
| def check(obj: AnyRef): Unit = { | |||
| val bos = new ByteArrayOutputStream() | |||
| val out = new ObjectOutputStream(println) // error | |||
| val out = new ObjectOutputStream(println) | |||
There was a problem hiding this comment.
I guess the overload is now resolved, but it's still a warning (OutputStream is not @FunctionalInterface), right?
There was a problem hiding this comment.
Yes, you get:
6 | val out = new ObjectOutputStream(println)
| ^^^^^^^
|method println is eta-expanded even though java.io.OutputStream does not have the @FunctionalInterface annotation.
|
Oh, one more semi-related question to eta-expansion of 0-argument methods. Is #2570 (comment) still the intended spec? Especially this part:
does not seem to be implemented: We're discussing this over in scala/scala#6475. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For overloading resolution, try a SAM type when no candidates are found.
Also, issue a warning when eta-expanding to a SAM type without a @FunctionalInterface
annotation.
Based on #4821