Code

Simplify Source Positions#5713

Code

Merged

odersky merged 102 commits intoscala:masterscala/scala3:masterfrom

dotty-staging:refactor-sourceposdotty-staging/dotty:refactor-sourceposCopy head branch name to clipboard

Jan 18, 2019

Commits

Commits on Jan 18, 2019

• Rename nextId -> nextSymId in Context

  Show description for f21bd00
  odersky

  committed
  f21bd00

  Copy full SHA for f21bd00

• Make nextTreeId counter a context field

  Show description for 4e25176
  odersky

  committed
  4e25176

  Copy full SHA for 4e25176

• Adapt refelect.TreeOps to new scheme

  odersky

  committed
  db6b9df

  Copy full SHA for db6b9df

• @transientParam annotation

  odersky

  committed
  b2e17fd

  Copy full SHA for b2e17fd

• Apply @transientParam to compiler

  Show description for 75d338d
  odersky

  committed
  75d338d

  Copy full SHA for 75d338d

• Produce tree ids in chunks

  Show description for 1a634c7
  odersky

  committed
  1a634c7

  Copy full SHA for 1a634c7

• Set source field of context directly

  Show description for c4ec3f6
  odersky

  committed
  c4ec3f6

  Copy full SHA for c4ec3f6

• Make TreeCopiers preserve source

  Show description for e86057d
  odersky

  committed
  e86057d

  Copy full SHA for e86057d

• Refactor getSource and withSource

  odersky

  committed
  6c13e88

  Copy full SHA for 6c13e88

• Serialize source file changes

  Show description for fc6daf0
  odersky

  committed
  fc6daf0

  Copy full SHA for fc6daf0

• Better caching of sources

  odersky

  committed
  3f938fb

  Copy full SHA for 3f938fb

• Allocate tree ids globally

  Show description for 9e705e9
  odersky

  committed
  9e705e9

  Copy full SHA for 9e705e9

• Follow source changes when unpickling

  odersky

  committed
  9abee3d

  Copy full SHA for 9abee3d

• Remove unpickleTypeTree

  odersky

  committed
  945c296

  Copy full SHA for 945c296

• Keep sourcefile info when pickling

  Show description for c8454e5
  odersky

  committed
  c8454e5

  Copy full SHA for c8454e5

• Eliminate Decorators.sourcePos

  odersky

  committed
  67786d0

  Copy full SHA for 67786d0

• Fix position of inline bodies in unpickler.

  odersky

  committed
  c85d707

  Copy full SHA for c85d707

• Lazy load contents of source position

  odersky

  committed
  eceeb1b

  Copy full SHA for eceeb1b

• Print full source positions in trees

  odersky

  committed
  b62a156

  Copy full SHA for b62a156

• Fix dropInlined

  odersky

  committed
  a68e776

  Copy full SHA for a68e776

• Check sources correspond under -Ytest-pickler

  odersky

  committed
  36e0212

  Copy full SHA for 36e0212

• Fix PositionPickler

  Show description for b3ebfb2
  odersky

  committed
  b3ebfb2

  Copy full SHA for b3ebfb2

• Make Inliner source-position aware

  odersky

  committed
  f0d1dfb

  Copy full SHA for f0d1dfb

• Fix Symbol#sourceFile

  Show description for 3a23f4b
  odersky

  committed
  3a23f4b

  Copy full SHA for 3a23f4b

• Make PositionPickler work for shared trees

  odersky

  committed
  6198884

  Copy full SHA for 6198884

• Make Modifiers not extend from Positioned

  Show description for 7bb25bd
  odersky

  committed
  7bb25bd

  Copy full SHA for 7bb25bd

• Temporary hack to circumvent missing sourcefile info

  Show description for 4d3fa4a
  odersky

  committed
  4d3fa4a

  Copy full SHA for 4d3fa4a

• Add source component to Positioned

  odersky

  committed
  bae1f6b

  Copy full SHA for bae1f6b

• Inliner tweaks

  Show description for 48f3367
  odersky

  committed
  48f3367

  Copy full SHA for 48f3367

• withPos(Positioned) -> withPosOf

  odersky

  committed
  7199965

  Copy full SHA for 7199965

• Unpickler always takes source from context

  Show description for cde9d60
  odersky

  committed
  cde9d60

  Copy full SHA for cde9d60

• withPos -> withSpan

  odersky

  committed
  1b39bd0

  Copy full SHA for 1b39bd0

• Fix position pickler

  Show description for 79eee51
  odersky

  committed
  79eee51

  Copy full SHA for 79eee51

• Harden IDE: Survive duplicate package and object

  odersky

  committed
  10a6db5

  Copy full SHA for 10a6db5

• Position -> Span

  odersky

  committed
  8699aa7

  Copy full SHA for 8699aa7

• Add missing check files

  odersky

  committed
  2d7e819

  Copy full SHA for 2d7e819

• Fix rebase breakage

  odersky

  committed
  50c3eef

  Copy full SHA for 50c3eef

• atPos -> atSpan

  odersky

  committed
  b136568

  Copy full SHA for b136568

• Rename SourcePos#pos -> SourcePos#span

  Show description for a1a87d9
  odersky

  committed
  a1a87d9

  Copy full SHA for a1a87d9

• Rename Span#pos -> Span#span

  Show description for 616bc85
  odersky

  committed
  616bc85

  Copy full SHA for 616bc85

• Rename Symbol#pos -> span, Comment#pos -> span

  odersky

  committed
  f7c76c2

  Copy full SHA for f7c76c2

• Apply renamings to language server

  odersky

  committed
  7c99d35

  Copy full SHA for 7c99d35

• Rename other uses of `pos` to `span`

  odersky

  committed
  cc5e90c

  Copy full SHA for cc5e90c

• Polishings

  odersky

  committed
  1404a4d

  Copy full SHA for 1404a4d

• Convert some checking methods to take Positioned arguments

  Show description for 58d8fbc
  odersky

  committed
  58d8fbc

  Copy full SHA for 58d8fbc

• Simplify Parser

  Show description for baf7dc1
  odersky

  committed
  baf7dc1

  Copy full SHA for baf7dc1

• Fix rebase breakage

  odersky

  committed
  18eaae0

  Copy full SHA for 18eaae0

• Add missing source to context

  

  nicolasstucki

  authored and

  odersky

  committed
  b1462cc

  Copy full SHA for b1462cc

• Add missing contents to vitual files

  

  nicolasstucki

  authored and

  odersky

  committed
  7d87656

  Copy full SHA for 7d87656

• Avoid memoization of virtual source files with same path

  

  nicolasstucki

  authored and

  odersky

  committed
  3de898e

  Copy full SHA for 3de898e

• Use non-virtual files in dottydoc tests

  Show description for bf6af32
  

  nicolasstucki

  authored and

  odersky

  committed
  bf6af32

  Copy full SHA for bf6af32

• Update test to use Spans

  

  nicolasstucki

  authored and

  odersky

  committed
  e160073

  Copy full SHA for e160073

• Update missing `pos` to `span`

  

  nicolasstucki

  authored and

  odersky

  committed
  57954c4

  Copy full SHA for 57954c4

• Update implicit modifier test

  Show description for a8adf1b
  

  nicolasstucki

  authored and

  odersky

  committed
  a8adf1b

  Copy full SHA for a8adf1b

• Add missing spans in closures

  Show description for 220a5fd
  

  nicolasstucki

  authored and

  odersky

  committed
  220a5fd

  Copy full SHA for 220a5fd

• Comment debug assertion

  

  nicolasstucki

  authored and

  odersky

  committed
  ec322f6

  Copy full SHA for ec322f6

• Remove unnecessary workaround for repl

  

  nicolasstucki

  authored and

  odersky

  committed
  f8be33f

  Copy full SHA for f8be33f

• Fix rebase breakage

  odersky

  committed
  14911e1

  Copy full SHA for 14911e1

• Avoid creating source positions in backend interface

  odersky

  committed
  70b5819

  Copy full SHA for 70b5819

• Optimize computation of Sourcefile#content

  odersky

  committed
  72a8765

  Copy full SHA for 72a8765

• Make SourceFile equals depend on file

  Show description for a22c366
  odersky

  committed
  a22c366

  Copy full SHA for a22c366

• Optimize equals + hashCode on PlainFile

  Show description for 4cf02c5
  odersky

  committed
  4cf02c5

  Copy full SHA for 4cf02c5

• Reduce concurrent hashmap lookups

  Show description for 77b4b4c
  odersky

  committed
  77b4b4c

  Copy full SHA for 77b4b4c

• Refactor SourceFile operations

  Show description for b915632
  odersky

  committed
  b915632

  Copy full SHA for b915632

• Optimize PlainFile.equals

  odersky

  committed
  e7c1d20

  Copy full SHA for e7c1d20

• Implement -Ydebug-pos

  Show description for 94b4b01
  odersky

  committed
  94b4b01

  Copy full SHA for 94b4b01

• Revise PositionPickler

  Show description for e021019
  odersky

  committed
  e021019

  Copy full SHA for e021019

• Fix rebase breakage

  odersky

  committed
  570e95c

  Copy full SHA for 570e95c

• Optimize initialPos in Positioned

  Show description for a44d43f
  odersky

  committed
  a44d43f

  Copy full SHA for a44d43f

• Optimize SourceFile.fromId

  odersky

  committed
  819f20f

  Copy full SHA for 819f20f

• Optimize Symbol#source

  Show description for aabdc75
  odersky

  committed
  aabdc75

  Copy full SHA for aabdc75

• Use SourceFile implicits instead of SourceInfo

  Show description for f740996
  odersky

  committed
  f740996

  Copy full SHA for f740996

• Make virtual source files explicit

  

  nicolasstucki

  authored and

  odersky

  committed
  a448629

  Copy full SHA for a448629

• Sourcefile refactoring

  Show description for fa3b4b9
  odersky

  committed
  fa3b4b9

  Copy full SHA for fa3b4b9

• Don't read contents when creating a source file

  odersky

  committed
  729a3d1

  Copy full SHA for 729a3d1

• Drop withPosOf and withSourcePos

  Show description for ed45da0
  odersky

  committed
  ed45da0

  Copy full SHA for ed45da0

• Don't ask defTree for Symbol's source after erasure

  Show description for decc730
  odersky

  committed
  decc730

  Copy full SHA for decc730

• Fix diagnostics breakage

  Show description for 1771a16
  odersky

  committed
  1771a16

  Copy full SHA for 1771a16

• Simplify source positions

  Show description for 17a901a
  odersky

  committed
  17a901a

  Copy full SHA for 17a901a

• Improve pickling of holes

  Show description for fe2d3ae
  odersky

  committed
  fe2d3ae

  Copy full SHA for fe2d3ae

• Avoid special cases in Positioned#envelope

  odersky

  committed
  953a6b1

  Copy full SHA for 953a6b1

• Compare sourcefiles structurally

  Show description for 7100da8
  odersky

  committed
  7100da8

  Copy full SHA for 7100da8

• Add missing spans in Desugar

  

  nicolasstucki

  authored and

  odersky

  committed
  7fa7a06

  Copy full SHA for 7fa7a06

• Fixes after rebase

  

  nicolasstucki

  authored and

  odersky

  committed
  e110858

  Copy full SHA for e110858

• Add missing span for tab complete

  

  nicolasstucki

  authored and

  odersky

  committed
  c2acbf0

  Copy full SHA for c2acbf0

• Add another missing span

  

  nicolasstucki

  authored and

  odersky

  committed
  e2966a9

  Copy full SHA for e2966a9

• Inferred TypedSplice spans

  

  nicolasstucki

  authored and

  odersky

  committed
  3558cb8

  Copy full SHA for 3558cb8

• Use the same virtual file for parsing and compiling in REPL

  

  nicolasstucki

  authored and

  odersky

  committed
  dec6b95

  Copy full SHA for dec6b95

• Use the index in the repl state for the line module

  

  nicolasstucki

  authored and

  odersky

  committed
  8e12771

  Copy full SHA for 8e12771

• Revert "Add missing spans in Desugar"

  Show description for 607ac1b
  

  nicolasstucki

  authored and

  odersky

  committed
  607ac1b

  Copy full SHA for 607ac1b

• Add missing span when expanding FunctionAppliedTo

  Show description for 791eb2b
  

  nicolasstucki

  authored and

  odersky

  committed
  791eb2b

  Copy full SHA for 791eb2b

• Update to compile with latest master

  odersky

  committed
  cac4e18

  Copy full SHA for cac4e18

• Add missing span when expanding FunctionAppliedTo

  Show description for 2244eb1
  nicolasstucki

  committed
  2244eb1

  Copy full SHA for 2244eb1

• Optimization: change Array.copy to System.arrayCopy

  Show description for 4ef3cea
  odersky

  committed
  4ef3cea

  Copy full SHA for 4ef3cea

• Rename Parser.atPos -> atSpan

  odersky

  committed
  21b3904

  Copy full SHA for 21b3904

• Track source changes in TreeMap and TreeAccumulator

  Show description for 360510c
  odersky

  committed
  360510c

  Copy full SHA for 360510c

• Address other review comments

  odersky

  committed
  829acf0

  Copy full SHA for 829acf0

• Rename transientParam -> constructorOnly

  odersky

  committed
  9fa170c

  Copy full SHA for 9fa170c

• Address overlooked comment

  odersky

  committed
  8d3b7ef

  Copy full SHA for 8d3b7ef

• Drop unnecessary compatibility hack

  Show description for 652b570
  odersky

  committed
  652b570

  Copy full SHA for 652b570

• Talk consistently about spans in Parser

  odersky

  committed
  570b26f

  Copy full SHA for 570b26f

• Address more review comments

  odersky

  committed
  fc2e654

  Copy full SHA for fc2e654