Fix error position and msg for expression expected #5693
Conversation
|
I just tried locally and it's a nice improvement. One minor suggestion, you might want to shift the offset to the character before the newline.
When the range encloses a newline the red squiggle appears on multiple lines. Would it make sense to apply this change for patterns?
Also, the error is different for types but I'm not sure how big of a change it would require to make it consistent with patterns and expressions.
|
1. Indicate error after last token only if it appears on line
before current token
2. Apply the same scheme to missing patterns
I tried to apply it to missing types as well, but there it is not so easy.
I got follow-up errors that I would not get with the existing scheme. So
in summary it's not clear that the change for types would be worth it.
| def expectedOffset: Int = { | ||
| val current = sourcePos(in.offset) | ||
| val last = sourcePos(in.lastOffset) | ||
| if (current.line != last.line) in.lastOffset else in.offset |
There was a problem hiding this comment.
I experienced two weird behaviors in vscode related to zero-length diagnostics microsoft/vscode#66482 and end-of-line diagnostics microsoft/vscode#66481 making the current diagnostics render like this
I was hoping they would render like this instead
It might be worth reverting the special handling of end-of-line diagnostics, but I'm not sure.
No description provided.