Code

Improve Source Positions#5644

Code

Closed

odersky wants to merge 75 commits intoscala:masterscala/scala3:masterfrom

dotty-staging:add-sourcepos-2dotty-staging/dotty:add-sourcepos-2Copy head branch name to clipboard

Commits

Commits on Jan 15, 2019

• Rename nextId -> nextSymId in Context

  Show description for 3227793
  odersky

  committed
  3227793

  Copy full SHA for 3227793

• Make nextTreeId counter a context field

  Show description for 2e3dab3
  odersky

  committed
  2e3dab3

  Copy full SHA for 2e3dab3

• Adapt refelect.TreeOps to new scheme

  odersky

  committed
  1cdae05

  Copy full SHA for 1cdae05

• @transientParam annotation

  odersky

  committed
  1b6a471

  Copy full SHA for 1b6a471

• Apply @transientParam to compiler

  Show description for 2cad642
  odersky

  committed
  2cad642

  Copy full SHA for 2cad642

• Produce tree ids in chunks

  Show description for d4779f1
  odersky

  committed
  d4779f1

  Copy full SHA for d4779f1

• Set source field of context directly

  Show description for f0451af
  odersky

  committed
  f0451af

  Copy full SHA for f0451af

• Make TreeCopiers preserve source

  Show description for 712adcc
  odersky

  committed
  712adcc

  Copy full SHA for 712adcc

• Refactor getSource and withSource

  odersky

  committed
  edaafd5

  Copy full SHA for edaafd5

• Serialize source file changes

  Show description for 1949b53
  odersky

  committed
  1949b53

  Copy full SHA for 1949b53

• Better caching of sources

  odersky

  committed
  454df0c

  Copy full SHA for 454df0c

• Allocate tree ids globally

  Show description for 368a68d
  odersky

  committed
  368a68d

  Copy full SHA for 368a68d

• Follow source changes when unpickling

  odersky

  committed
  03b3ac8

  Copy full SHA for 03b3ac8

• Remove unpickleTypeTree

  odersky

  committed
  559defd

  Copy full SHA for 559defd

• Keep sourcefile info when pickling

  Show description for 7f63293
  odersky

  committed
  7f63293

  Copy full SHA for 7f63293

• Eliminate Decorators.sourcePos

  odersky

  committed
  19f3bde

  Copy full SHA for 19f3bde

• Fix position of inline bodies in unpickler.

  odersky

  committed
  8d9f3ca

  Copy full SHA for 8d9f3ca

• Lazy load contents of source position

  odersky

  committed
  1ce8b59

  Copy full SHA for 1ce8b59

• Print full source positions in trees

  odersky

  committed
  3c56fa6

  Copy full SHA for 3c56fa6

• Fix dropInlined

  odersky

  committed
  4a5d09a

  Copy full SHA for 4a5d09a

• Check sources correspond under -Ytest-pickler

  odersky

  committed
  9f54f73

  Copy full SHA for 9f54f73

• Fix PositionPickler

  Show description for 30008ae
  odersky

  committed
  30008ae

  Copy full SHA for 30008ae

• Make Inliner source-position aware

  odersky

  committed
  ed27a4e

  Copy full SHA for ed27a4e

• Fix Symbol#sourceFile

  Show description for a1e367b
  odersky

  committed
  a1e367b

  Copy full SHA for a1e367b

• Make PositionPickler work for shared trees

  odersky

  committed
  56b313a

  Copy full SHA for 56b313a

• Make Modifiers not extend from Positioned

  Show description for b8e23f4
  odersky

  committed
  b8e23f4

  Copy full SHA for b8e23f4

• Temporary hack to circumvent missing sourcefile info

  Show description for 9f86d2f
  odersky

  committed
  9f86d2f

  Copy full SHA for 9f86d2f

• Add source component to Positioned

  odersky

  committed
  e22d702

  Copy full SHA for e22d702

• Inliner tweaks

  Show description for 27a7a77
  odersky

  committed
  27a7a77

  Copy full SHA for 27a7a77

• withPos(Positioned) -> withPosOf

  odersky

  committed
  91af81a

  Copy full SHA for 91af81a

• Unpickler always takes source from context

  Show description for 2907634
  odersky

  committed
  2907634

  Copy full SHA for 2907634

• withPos -> withSpan

  odersky

  committed
  14d2c5a

  Copy full SHA for 14d2c5a

• Fix position pickler

  Show description for 6f6d1ab
  odersky

  committed
  6f6d1ab

  Copy full SHA for 6f6d1ab

• Harden IDE: Survive duplicate package and object

  odersky

  committed
  3f09d91

  Copy full SHA for 3f09d91

• Position -> Span

  odersky

  committed
  6c07a94

  Copy full SHA for 6c07a94

• Add missing check files

  odersky

  committed
  cf94fc4

  Copy full SHA for cf94fc4

• Fix rebase breakage

  odersky

  committed
  012c5e9

  Copy full SHA for 012c5e9

• atPos -> atSpan

  odersky

  committed
  ca4e463

  Copy full SHA for ca4e463

• Rename SourcePos#pos -> SourcePos#span

  Show description for dbc5251
  odersky

  committed
  dbc5251

  Copy full SHA for dbc5251

• Rename Span#pos -> Span#span

  Show description for 6c88c93
  odersky

  committed
  6c88c93

  Copy full SHA for 6c88c93

• Rename Symbol#pos -> span, Comment#pos -> span

  odersky

  committed
  a958ece

  Copy full SHA for a958ece

• Apply renamings to language server

  odersky

  committed
  1d16fab

  Copy full SHA for 1d16fab

• Rename other uses of `pos` to `span`

  odersky

  committed
  70768fa

  Copy full SHA for 70768fa

• Polishings

  odersky

  committed
  39c4ca5

  Copy full SHA for 39c4ca5

• Convert some checking methods to take Positioned arguments

  Show description for 7dc693e
  odersky

  committed
  7dc693e

  Copy full SHA for 7dc693e

• Simplify Parser

  Show description for 0a00ed2
  odersky

  committed
  0a00ed2

  Copy full SHA for 0a00ed2

• Fix rebase breakage

  odersky

  committed
  078a491

  Copy full SHA for 078a491

• Add missing source to context

  

  nicolasstucki

  authored and

  odersky

  committed
  fc3020b

  Copy full SHA for fc3020b

• Add missing contents to vitual files

  

  nicolasstucki

  authored and

  odersky

  committed
  2150fdd

  Copy full SHA for 2150fdd

• Avoid memoization of virtual source files with same path

  

  nicolasstucki

  authored and

  odersky

  committed
  fa08b7e

  Copy full SHA for fa08b7e

• Use non-virtual files in dottydoc tests

  Show description for 57e893f
  

  nicolasstucki

  authored and

  odersky

  committed
  57e893f

  Copy full SHA for 57e893f

• Update test to use Spans

  

  nicolasstucki

  authored and

  odersky

  committed
  6188f37

  Copy full SHA for 6188f37

• Update missing `pos` to `span`

  

  nicolasstucki

  authored and

  odersky

  committed
  ba52c01

  Copy full SHA for ba52c01

• Update implicit modifier test

  Show description for ff7a87e
  

  nicolasstucki

  authored and

  odersky

  committed
  ff7a87e

  Copy full SHA for ff7a87e

• Add missing spans in closures

  Show description for d0d6393
  

  nicolasstucki

  authored and

  odersky

  committed
  d0d6393

  Copy full SHA for d0d6393

• Comment debug assertion

  

  nicolasstucki

  authored and

  odersky

  committed
  5413f87

  Copy full SHA for 5413f87

• Remove unnecessary workaround for repl

  

  nicolasstucki

  authored and

  odersky

  committed
  1f7ab41

  Copy full SHA for 1f7ab41

• Fix rebase breakage

  odersky

  committed
  19cf827

  Copy full SHA for 19cf827

• Avoid creating source positions in backend interface

  odersky

  committed
  6491872

  Copy full SHA for 6491872

• Optimize computation of Sourcefile#content

  odersky

  committed
  512d7c3

  Copy full SHA for 512d7c3

• Make SourceFile equals depend on file

  Show description for a2f437a
  odersky

  committed
  a2f437a

  Copy full SHA for a2f437a

• Optimize equals + hashCode on PlainFile

  Show description for cb3515b
  odersky

  committed
  cb3515b

  Copy full SHA for cb3515b

• Reduce concurrent hashmap lookups

  Show description for d1008fc
  odersky

  committed
  d1008fc

  Copy full SHA for d1008fc

• Refactor SourceFile operations

  Show description for 4421092
  odersky

  committed
  4421092

  Copy full SHA for 4421092

• Optimize PlainFile.equals

  odersky

  committed
  c03e31b

  Copy full SHA for c03e31b

• Implement -Ydebug-pos

  Show description for 036546f
  odersky

  committed
  036546f

  Copy full SHA for 036546f

• Revise PositionPickler

  Show description for 7947349
  odersky

  committed
  7947349

  Copy full SHA for 7947349

• Fix rebase breakage

  odersky

  committed
  29c8f45

  Copy full SHA for 29c8f45

• Optimize initialPos in Positioned

  Show description for a7a8203
  odersky

  committed
  a7a8203

  Copy full SHA for a7a8203

• Optimize SourceFile.fromId

  odersky

  committed
  a3ee7c0

  Copy full SHA for a3ee7c0

• Optimize Symbol#source

  Show description for 66ebabd
  odersky

  committed
  66ebabd

  Copy full SHA for 66ebabd

• Use SourceFile implicits instead of SourceInfo

  Show description for 8ed8723
  odersky

  committed
  8ed8723

  Copy full SHA for 8ed8723

• Make virtual source files explicit

  

  nicolasstucki

  authored and

  odersky

  committed
  5a6b1ee

  Copy full SHA for 5a6b1ee

• Sourcefile refactoring

  Show description for 84321eb
  odersky

  committed
  84321eb

  Copy full SHA for 84321eb

• Don't read contents when creating a source file

  odersky

  committed
  f5e226d

  Copy full SHA for f5e226d