Skip to content

Enclose runMain in try-catch #5615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2019
Merged

Enclose runMain in try-catch #5615

merged 2 commits into from
Jan 4, 2019

Conversation

biboudis
Copy link
Contributor

If an author writes a run test with an object other than "Test" they get back the general invocation exception of invoke which is not very informative. This catches other exception like ones originating from loadClass.

@biboudis biboudis self-assigned this Dec 15, 2018
allanrenucci
allanrenucci approved these changes Dec 18, 2018
View reviewed changes
@biboudis
Copy link
Contributor Author

biboudis commented Jan 4, 2019

@dotty-bot recheck cla

@biboudis biboudis merged commit 2b31453 into scala:master Jan 4, 2019
@biboudis biboudis deleted the try-child-jvm-main branch January 4, 2019 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci approved these changes

Assignees

@biboudis biboudis

Labels
area:infrastructure area:testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biboudis @allanrenucci