Skip to content

fix windows path (see #5560) #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2018
Merged

fix windows path (see #5560) #5587

merged 1 commit into from
Dec 10, 2018

Conversation

michelou
Copy link
Contributor

@michelou michelou commented Dec 10, 2018

This is similar to #5560 change in source file compiler/src/dotty/tools/dotc/quoted/QuoteDriver.scala for build/tests to succeed on Windows:

url.getFilePaths.get(url.toURI).toString

NB. Build/tests on Windows are executed thanks to #5444 (pending PR).

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @michelou

@allanrenucci allanrenucci merged commit 172d6a0 into scala:master Dec 10, 2018
@michelou michelou deleted the compiler-test branch December 10, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants