Fix #4785: Change typing rule for wildcard star args #5577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
force-pushed
the
fix-4785
branch
4 times, most recently
from
3204913 to
d52125b
Compare
odersky
reviewed
Dec 9, 2018
| @@ -91,12 +96,10 @@ class ElimRepeated extends MiniPhase with InfoTransformer { thisPhase => | |||
| private def seqToArray(tree: Tree, pt: Type)(implicit ctx: Context): Tree = tree match { | |||
| case SeqLiteral(elems, elemtpt) => | |||
| JavaSeqLiteral(elems, elemtpt) | |||
| case app@Apply(fun, args) if defn.WrapArrayMethods().contains(fun.symbol) => // rewrite a call to `wrapXArray(arr)` to `arr` | |||
There was a problem hiding this comment.
Why was this optimization dropped?
There was a problem hiding this comment.
It is no longer needed. When calling into java repeated we used to insert an implicit conversion from Array to Seq that we later reverted. For example:
def test(xs: Array[String]) = Paths.get("Hello", xs: _*)Before this patch:
// after frontend:
def test(xs: Array[String]) = Paths.get("Hello", wrapRefArray[String](xs):String*)
// after elimRepeated
def test(xs: Array[String]): = Paths.get("Hello", xs)After this patch:
// after frontend:
def test(xs: Array[String]) = Paths.get("Hello", xs:String*) // no more call to wrapRefArray
// after elimRepeated
def test(xs: Array[String]): = Paths.get("Hello", xs)
We typecheck them without expected type to avoid relying on the implicit conversion from Array to Seq defined in Predef. ElimRepeated does the necessary adaptations (i.e. seqToArray and arrayToSeq conversions).
This is not necessary anymore after scala#5403
allanrenucci
force-pushed
the
fix-4785
branch
from
d52125b to
47d969f
Compare
|
Comments addressed |
odersky
approved these changes
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We typecheck them without expected type to avoid relying on the implicit
conversion from Array to Seq defined in Predef. ElimRepeated does the
necessary adaptations (i.e. seqToArray and arrayToSeq conversions).