Skip to content

Add missing TASTy reflect instance checks #5504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2018
Merged

Add missing TASTy reflect instance checks #5504

merged 3 commits into from
Nov 26, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Nov 23, 2018
@nicolasstucki nicolasstucki force-pushed the add-missing-tasty-instance-checks branch from e5c0f50 to 8e5b76d Compare November 23, 2018 10:23
@nicolasstucki nicolasstucki changed the title Add missing tasty instance checks Add missing TASTy reflect instance checks Nov 23, 2018
liufengyun
liufengyun approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For later refactoring: maybe a better name than IsXXX, which suggests a boolean extractor.

@nicolasstucki nicolasstucki merged commit 63ee01a into scala:master Nov 26, 2018
@nicolasstucki nicolasstucki deleted the add-missing-tasty-instance-checks branch November 26, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun