Fix/#536 nested classes #544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y compiled. It seems wasteful to load the member classes even of classes that are not currently compiled. It also makes us vulnerable to any misinterpretation of Java file formats. In th particular case of scala#536, we parsed a class an anonymous Collection$1 which was referring to the type parameter of its enclosing class, but was not diagnosed as an inner class of the enclosing class.
…ate. Symbols never change betwene terms and types. So we do not need to the current denotation to decide what they are. Less forcing -> less potential for cyclic references.
|
Otherwise LGTM, after tests pass. |
| def nestedClasses: List[Symbol] = memberClasses //exitingPhase(currentRun.lambdaliftPhase)(sym.memberClasses) | ||
| def memberClasses: List[Symbol] = toDenot(sym).info.memberClasses.map(_.symbol).toList | ||
|
|
||
| /** For currently compiled classes: All locally defined classes including local classes. |
There was a problem hiding this comment.
What's the difference between a "locally defined class" and a "local class"? Also what about using the description "classes defined in the current symbol scope" or something like that?
|
Merging this PR with #543 |
DarkDimius
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 8, 2015
…his run. See discussion in scala#544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #536. It makes the bet that member classes are only needed for classes that are currently compiled. It also fixes the implementation of memberClasses and localClasses, which was not according to spec before.
Review by @smarter, @DarkDimius