Add specializing inline #5383
Merged
Add specializing inline #5383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Nov 4, 2018
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
odersky
force-pushed
the
add-specializing-inline
branch
2 times, most recently
from
5a360ec to
c8398e8
Compare
odersky
force-pushed
the
add-specializing-inline
branch
2 times, most recently
from
01ae482 to
fb919a5
Compare
odersky
force-pushed
the
add-specializing-inline
branch
from
fb919a5 to
221d337
Compare
Reverts the following commits: Join containsQuotesOrSplices and containsInlineCalls (reverted from commit 8cf1385) Make InlineCalls an object (reverted from commit ad26554) Remove Inlined and InlineProxy from TASTy (reverted from commit 976e095) Move inlining inside Reify quotes Split some neg tests as now only the first error is emitted. (reverted from commit 21e65f1) Erase rhs of erased non inlined val/def in PostTyper (reverted from commit c12e875) Add isInlineCall to TreeInfo (reverted from commit 954c25b) Update doc (reverted from commit 0832e02) Only run InlineCalls if the tree contains an inline call (reverted from commit f28e2e1) Check if unpickled tree has inline nodes (reverted from commit 927ae4e) Add a bit of documentation (reverted from commit da0c249) Fix constant folding during inlining (reverted from commit 32c8798) Move inline β-reduction after Pickler (reverted from commit c68dc1f) Normalize call at Inlined node creation (reverted from commit 746fdd7) Move inline β-reduction after post typer (reverted from commit 432eb0a) Move inline β-reduction out of typer (reverted from commit 6acaf31)
- add new syntax - an inline method with an explicit `: T` result type section has its rhs upcasted to its return type. It was an oversight that this was not done before.
This affects both RefinedPrinter and ShowSougrceCode. Another example of the tax we pay for maintaining both. It required Chars to be moved to scala.tasty.
nicolasstucki
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds
<: Treturn type syntax for inline methods and handles upcasting properly. The body of aninlinemethod is upcasted to its return type, provided a return type is given with: T(as opposed to
<: T).We previously did not do this which meant that all inline methods had some degree of whiteboxity even though it was claimed otherwise.
This PR is based on #5382.