Skip to content

Remove separate compilation tests for pickling blacklist #5357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

nicolasstucki
Copy link
Contributor

Adding new separate compilation is quite annoying because we have to add them all to the pickling blacklist. Moving separate compilation tests to their own folder fixes this issue.

@smarter
Copy link
Member

smarter commented Oct 31, 2018

Why do all separate compilation tests need to be in the pickling blacklist?

@nicolasstucki
Copy link
Contributor Author

I do not remember the details but it was a known issue when @OlivierBlanvillain added the blacklist. The pickling tests framework assumed that all files are compiled together.

@allanrenucci
Copy link
Contributor

Why do all separate compilation tests need to be in the pickling blacklist?

IIRC pickling tests stop after pickling, so separate compilation cannot work since the first compilation does not produce anything

@smarter
Copy link
Member

smarter commented Nov 1, 2018

If we get them to output .tasty files that should be enough to get separate compilation working (possibly with some extra stuff from my parallel Dotty PR where I rely on that, cant remember)

@OlivierBlanvillain
Copy link
Contributor

👍

@nicolasstucki
Copy link
Contributor Author

When we get the extra stuff from the parallel PR in we can just move back this files to run and pos

@nicolasstucki nicolasstucki force-pushed the clean-pickling-blacklist branch from 217c64f to acd604e Compare November 2, 2018 13:39
@nicolasstucki
Copy link
Contributor Author

Rebased

@nicolasstucki nicolasstucki merged commit d13a467 into scala:master Nov 2, 2018
@allanrenucci allanrenucci deleted the clean-pickling-blacklist branch November 2, 2018 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants