Fix #518 - compute denotations #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If previous denotation was a sym denotation, it might be overridden by a different symbol in a new phase or run. So it is not correct to simply return the current version of the symbol, as was done before. We now recompute the member if there is a chance that the symbol could be overridden.
Phase ExtensionMethods creates new symbols for extension methods and then installs these symbols into the companion object of a value class. It's important that the creation of these symbols is done in the phase ExtensionMethods itself, and not in the next phase, as was done before. If we do it in the next phase, we need the owner at the next phase and with the new scheme of computeDenot that owner might be forced, leading to an infinite cycle.
Tests scala#518.
Allow to rebind a NmedType to refer to a symbol in a subclass of where the previous symbol was defined. This generalizes the previous rule that we allow to rebind from a root method to its synthetic implementation. The change is not necessary to make the new scheme of computeDenot pass the tests, but it seems useful to avoid spurious errors elsehere.
|
LGTM |
isWeakRef was confusing because this has nothing to do with weak pointers.
|
The build hangs on travis after this PR was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take overriding into account when cpmputing denotations. Fixes #518. Review by @smarter @DarkDimius