Skip to content

Fix #5271: Use typed elements #5322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2018
Merged

Fix #5271: Use typed elements #5322

merged 1 commit into from
Oct 25, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

Blaisorblade
Blaisorblade reviewed Oct 25, 2018
View reviewed changes
Blaisorblade
Blaisorblade approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — looks like this branch was likely never tested!

@Blaisorblade Blaisorblade removed their assignment Oct 25, 2018
@nicolasstucki
Copy link
Contributor Author

It was tested but only with literal constants. Those trees have a type even when untyped.

@nicolasstucki nicolasstucki merged commit 8031978 into scala:master Oct 25, 2018
@nicolasstucki nicolasstucki deleted the fix-#5271 branch October 25, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blaisorblade Blaisorblade Blaisorblade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @Blaisorblade