Remove Worksheet dependency on JLine #5320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The worksheet used to spawn a REPL with JLine just to be able to read from an InputStream. This is alternative solution that simply uses java.util.Scanner to read from an InputStream. For that, we need to agree on a delimiter. We choose a character within the private user area to not conflict with the output produced by the REPL.
|
Running a thread in the same process does not protect against OufOtOfMemoryException, calls to System.exit, etc. Ideally I think we should have a repl server protocol and communicate with the repl process that way. |
allanrenucci
force-pushed
the
worksheet
branch
from
30be3cb to
3865ba6
Compare
smarter
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The worksheet used to spawn a REPL with JLine just to be able to read
from an InputStream.
This is alternative solution that simply uses java.util.Scanner to read
from an InputStream. For that, we need to agree on a delimiter. We
choose a character within the private user area to not conflict with
the output produced by the REPL.