Fix compatibility of Java with value classes #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix/vc-java-compat
branch
from
ec9cfce to
656c248
Compare
|
@smarter can you add a testcase? |
|
Otherwise LGTM |
This avoids getting a runtime error when calling a Java-defined method whose signature contains value classes. It happened because we erased the value classes in this signature even though it comes from a classfile. Amusingly, this problem also exists in scalac: <https://issues.scala-lang.org/browse/SI-9298>
smarter
force-pushed
the
fix/vc-java-compat
branch
from
656c248 to
e8f3224
Compare
|
Test added. |
DarkDimius
added a commit
that referenced
this pull request
May 4, 2015
Fix compatibility of Java with value classes
|
Probably worth a look at scala/scala@44b9cf0 which introduced nuanced erasure to Scala based on whether the symbol was Java/Scala, or constructor/non-constructor. |
|
@retronym we already have different erasure for java-defined symbol, with different glb. |
|
I was echoing a comment in that commit. Looking back a bit further, I think it refers to the special case that the result type of a value class constructor should not erase to the underlying: scala/scala@e171d6d I guess you have that covered already. |
scala> case class C(val i: Int) extends AnyVal
defined class C
scala> :power
scala> val constructor = symbolOf[C].primaryConstructor
constructor: $r.intp.global.Symbol = constructor C
scala> erasure.specialErasure(constructor)(constructor.info)
res5: $r.intp.global.erasure.global.Type = (i: Int)C
scala> erasure.specialErasure(NoSymbol)(constructor.info)
res6: $r.intp.global.erasure.global.Type = (i: Int)ErasedValueType(class C, Int) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by @odersky.