Skip to content

Add tuple >22 test cases from #2199 #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

OlivierBlanvillain
Copy link
Contributor

4 of these tests are failing, I put them in pending for now.
Interestingly each of them fails in different ways:

Compiler crash
tests/pending/tuple-patmat-extract.scala

Compilation error
tests/pending/tuple-for-comprehension.scala

Runtime error
tests/pending/tuple-erased.scala

Doesn't pass Ycheck
tests/pending/tuple-cons.scala

4 of these tests are failing, I put them in pending for now.
Interestingly each of them fails in different ways:

Compiler crash
tests/pending/tuple-patmat-extract.scala

Compilation error
tests/pending/tuple-for-comprehension.scala

Runtime error
tests/pending/tuple-erased.scala

Doesn't pass Ycheck
tests/pending/tuple-cons.scala
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGT. We should add an issue for each pending test.

@nicolasstucki nicolasstucki merged commit 39e6a49 into scala:master Oct 17, 2018
@nicolasstucki nicolasstucki deleted the tuple-tests branch October 17, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants