Skip to content

Add checkTypes to support type unit testing #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

milessabin
Copy link
Contributor

@milessabin milessabin commented Oct 11, 2018

Implementation mostly stolen from TypeStealer.

CheckTypesTests are tests of DottyTest#checkTypes(s) rather than of <:<.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

Implementation mostly stolen from TypeStealer.
@milessabin
Copy link
Contributor Author

Squashed. Also added a variant which takes multiple lists of type strings, primarily to support lists of expected results.

@milessabin
Copy link
Contributor Author

@smarter I've tweaked this slightly (see above) ... if you're still happy I'll merge.

@smarter
Copy link
Member

smarter commented Oct 15, 2018

sure!

@milessabin milessabin merged commit d3a0ac8 into scala:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants