Move inlining into ReifyQuotes and remove Inlined from TASTy #5241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
move-inlining-in-reify-quotes
branch
2 times, most recently
from
22575d7 to
cdeaa8d
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
move-inlining-in-reify-quotes
branch
from
50a204c to
eaf395a
Compare
nicolasstucki
force-pushed
the
move-inlining-in-reify-quotes
branch
from
eaf395a to
6338e53
Compare
nicolasstucki
force-pushed
the
move-inlining-in-reify-quotes
branch
2 times, most recently
from
be873c9 to
23b1530
Compare
nicolasstucki
force-pushed
the
move-inlining-in-reify-quotes
branch
from
23b1530 to
cf730b5
Compare
Split some neg tests as now only the first error is emitted.
nicolasstucki
force-pushed
the
move-inlining-in-reify-quotes
branch
from
cf730b5 to
976e095
Compare
odersky
reviewed
Oct 26, 2018
| @@ -2,7 +2,7 @@ package dotty.tools.dotc.decompiler | |||
|
|
|||
| import dotty.tools.dotc.fromtasty._ | |||
| import dotty.tools.dotc.core.Phases.Phase | |||
| import dotty.tools.dotc.transform.InlineCalls | |||
| import dotty.tools.dotc.transform.ReifyQuotes | |||
There was a problem hiding this comment.
We should think about a name for both inlining and quoting and splicing.
There was a problem hiding this comment.
Maybe Staging
odersky
approved these changes
Oct 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5216