Decouple saving and running the worksheet #5238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
worksheet-stuff-2
branch
2 times, most recently
from
1b4b69c to
208af0b
Compare
Duhemm
reviewed
Oct 11, 2018
vscode-dotty/src/worksheet.ts
Outdated
| this.removeRedundantBlankLines().then(_ => this.reset()) | ||
| } | ||
|
|
||
| /** | ||
| * Run the worksheet in `document`, display a progress bar during the run. | ||
| */ | ||
| run(): Thenable<{}> { | ||
| this.prepareRun() |
There was a problem hiding this comment.
So you run the worksheet without it being saved, which will work because the compiler doesn't run it from the source that is in the file, but from the source that it received in textDocument/didChange, right?
- Do not automatically save the worksheet when the run command is executed. - Make it possible to save the worksheet without running it (by setting the configuration value dotty.runWorksheetOnSave to false)
smarter
force-pushed
the
worksheet-stuff-2
branch
from
208af0b to
7c871cc
Compare
- Replaced removeRedundantBlankLines by removeRedundantBlankLinesEdit which doesn't have side-effects but returns an array of TextEdit - Fixed onWillSaveTextDocument to call event.waitUntil which is the only way to actually apply changes synchronously. - Removed the return in onDidSaveTextDocument, the result of the lambda for an event isn't actually used for anything - Changed Worksheet#run() to have a more precise result type and to only run something if prepareRun() succeeded.
smarter
force-pushed
the
worksheet-stuff-2
branch
from
7c871cc to
6640161
Compare
Duhemm
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executed.
the configuration value dotty.runWorksheetOnSave to false)