-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #5188: See through annotations and typevars when computing argume… #5215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:
- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
The commit message has a typo, #5198 is not an issue. |
I guess it was supposed to be #5188. Is that correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the commit message and add tests
See through annotations (and typevars) when computing argument types.
Yes, #5188. I changed the commit message. |
Now I get in -Ycheck:all:
The problem is that the varargs 1, 2, 3 are known values, but their translation SeqLiteral(1, 2, 3) is not. @nicolasstucki can you see what we should do about it? We could just disable the |
I will have a look. |
ff4a4d6
to
94987ea
Compare
The fix in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See through annotations (and typevars) when computing argument types.