Skip to content

Implement tuple with quotes #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2018
Merged

Implement tuple with quotes #5182

merged 1 commit into from
Oct 7, 2018

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Sep 30, 2018 •
edited
Loading

@nicolasstucki nicolasstucki mentioned this pull request Sep 30, 2018
Closed
@nicolasstucki nicolasstucki force-pushed the implement-tuple-with-quotes branch 3 times, most recently from f865e06 to 2bc4024 Compare October 1, 2018 00:22
@nicolasstucki nicolasstucki self-assigned this Oct 1, 2018
@nicolasstucki nicolasstucki force-pushed the implement-tuple-with-quotes branch from 2bc4024 to 0c28594 Compare October 1, 2018 16:23
@biboudis biboudis self-requested a review October 2, 2018 14:22
@nicolasstucki nicolasstucki force-pushed the implement-tuple-with-quotes branch 3 times, most recently from 3f11258 to 5b58288 Compare October 4, 2018 15:22
@nicolasstucki nicolasstucki force-pushed the implement-tuple-with-quotes branch from 5b58288 to 2b8ca0a Compare October 4, 2018 15:25
@nicolasstucki nicolasstucki requested a review from odersky October 4, 2018 16:13
@allanrenucci allanrenucci mentioned this pull request Oct 5, 2018
Closed
8 tasks
odersky
odersky approved these changes Oct 6, 2018
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We really should try to make ' and operator like ~, that would save us one pair of parentheses.

@nicolasstucki
Copy link
Contributor Author

It would be great. The only thing blocking us are the symbol literals. Maybe as a compromise for migration to still support them we could have a language flag that changes the meaning of ' without parentheses.

@nicolasstucki nicolasstucki merged commit 5aa2f9c into scala:master Oct 7, 2018
@nicolasstucki nicolasstucki deleted the implement-tuple-with-quotes branch October 7, 2018 09:18
@nicolasstucki nicolasstucki mentioned this pull request Oct 17, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

@biboudis biboudis Awaiting requested review from biboudis

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @odersky