Skip to content

Don't report Dynamic inheritance warning on Dynamic itself #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

allanrenucci
Copy link
Contributor

Compiling the standard library, we used to get this warning:

-- Feature Warning: Test.scala:3:6 ---------------------------------
3 |trait Dynamic extends Any
  |^^^^^^^^^^^^^^^^^^^^^^^^^
  |extension of type scala.Dynamic should be enabled
  |by making the implicit value scala.language.dynamics visible.
  |This can be achieved by adding the import clause 'import scala.language.dynamics'
  |or by setting the compiler option -language:dynamics.
  |See the Scala docs for value scala.language.dynamics for a discussion
  |why the feature should be explicitly enabled.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 6317000 into scala:master Sep 28, 2018
@liufengyun liufengyun deleted the dynamic branch September 28, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants