Skip to content

Fix offset of token EOF #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compiler/src/dotty/tools/dotc/parsing/CharArrayReader.scala
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ abstract class CharArrayReader { self =>
final def nextChar(): Unit = {
val idx = charOffset
lastCharOffset = idx
charOffset = idx + 1
if (idx >= buf.length) {
ch = SU
} else {
val c = buf(idx)
ch = c
charOffset = idx + 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered applying this fix to nextRawChar as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

if (c == '\\') potentialUnicode()
else if (c < ' ') { skipCR(); potentialLineEnd() }
}
Expand All @@ -59,12 +59,12 @@ abstract class CharArrayReader { self =>
final def nextRawChar(): Unit = {
val idx = charOffset
lastCharOffset = idx
charOffset = idx + 1
if (idx >= buf.length) {
ch = SU
} else {
val c = buf(charOffset)
val c = buf(idx)
ch = c
charOffset = idx + 1
if (c == '\\') potentialUnicode()
}
}
Expand Down
6 changes: 4 additions & 2 deletions compiler/test-resources/repl/i2213
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ scala> def x
1 | def x
| ^
| missing return type
1 | def x

scala> def x: Int
1 | def x: Int
| ^
| '=' expected, but eof found
|declaration of method x not allowed here: only classes can have declared but undefined members
3 changes: 2 additions & 1 deletion tests/neg/i2494.scala
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
enum
object // error // error
object // error
// error
3 changes: 2 additions & 1 deletion tests/neg/i4373a.scala
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// ==> 040fb47fbaf718cecb11a7d51ac5a48bf4f6a1fe.scala <==
object x0 {
val x0 : _ with // error // error // error
val x0 : _ with // error // error
// error
3 changes: 2 additions & 1 deletion tests/neg/i4373b.scala
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// ==> 05bef7805687ba94da37177f7568e3ba7da1f91c.scala <==
class x0 {
x1: // error
x0 | _ // error // error
x0 | _ // error
// error
3 changes: 2 additions & 1 deletion tests/neg/i4373c.scala
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// ==> 18b253a4a89a84c5674165c6fc3efafad535eee3.scala <==
object x0 {
def x1[x2 <:_[ // error // error // error
def x1[x2 <:_[ // error // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-1.scala
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
object x0 {
x1 match // error
def this // error // error
def this // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-10.scala
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ def unapply(i1: Int)(i6: List[Int]): Int = {
object i5 {
import collection.mutable._
try { ??? mutable { case i1(i5, i3, i4) => i5 }} // error // error // error
} // error
}
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-11.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ package x0 {
case class x0 // error // error
}
package x0
class x0 // error // error
class x0 // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-12.scala
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
trait x0[] // error
trait x1[x1 <:x0]
extends x1[ // error
extends x1[
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-14.scala
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
object x0 {
{
val x1 x0 // error
object x1 // error // error
object x1 // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-15.scala
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ class x0 {
def x1 =
x2 match // error
] // error
case x3[] => x0 // error // error // error // error
case x3[] => x0 // error // error // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-16.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ class x0[x0] {
val x1 : x0
}
trait x3 extends x0 {
x1 = 0 object // error // error
x1 = 0 object // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-18.scala
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
trait x0 {
class x1 (x1:x0
{
type x1 <: List[x1 <: // error // error
type x1 <: List[x1 <: // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-19.scala
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
object x0 {
case class x0[] // error // error
def x0( ) ] // error // error
def x0 ( x0:x0 ):x0.type = x1 x0 // error // error // error
def x0 ( x0:x0 ):x0.type = x1 x0 // error // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-2.scala
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
trait x0 {
new _ // error // error
new _ // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-20.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ object x0 {
def unapply= Array
x0 match
x0 // error
case x0( // error // error
case x0( // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-21.scala
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
class x0[x1[]] // error
extends x1[ // error // error
extends x1[ // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-22.scala
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
package x0.x0 {}
object x0 {
def x0 (implicit // error // error
def x0 (implicit // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-3.scala
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
object x0 {
def x0(x1: x2 = 0, x1 x3) x4 = // error // error // error
x5 x6 x7[x8[x9 x2]] = x0
val x10 = x0( ) // error // error
val x10 = x0( ) // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-4.scala
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
class x0{
def x0: x0 = (x0 => x0) => x0) // error // error
def x0: x0 = (x0 => x0) => x0) // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-5.scala
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
trait x0 {
x1 : { // error
var x2 // error // error
var x2 // error
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability-9.scala
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
import // error
import
// error
3 changes: 2 additions & 1 deletion tests/neg/parser-stability.scala
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
class I2[I2] {
def I2: I2 = (I2 => I2) => I2 // error // error
def I2: I2 = (I2 => I2) => I2 // error
// error