Fix issue #5124 #5125
Merged
Fix issue #5124 #5125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Sep 19, 2018
smarter
approved these changes
Sep 19, 2018
| val dottyIdeJson: String = | ||
| s"""[ { | ||
| | "id" : "dotty-ide-test", | ||
| | "compilerVersion" : "${BuildInfo.ideTestsCompilerVersion}", | ||
| | "compilerArguments" : ${showSeq(BuildInfo.ideTestsCompilerArguments)}, | ||
| | "sourceDirectories" : ${showSeq(BuildInfo.ideTestsSourceDirectories)}, | ||
| | "dependencyClasspath" : ${showSeq(BuildInfo.ideTestsDependencyClasspath)}, | ||
| | "classDirectory" : "${BuildInfo.ideTestsClassDirectory}" | ||
| | "classDirectory" : "${BuildInfo.ideTestsClassDirectory.toString().replace('\\','/')}" |
There was a problem hiding this comment.
No need for the parentheses after toString
There was a problem hiding this comment.
Sorry, Java habits. Will fix.
Should I amend or just new commit is OK?
|
New commit is fine here, in general we don't have a strong policy for commits, but I personally prefer having a clean history when possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides small fix for #5124. After applying it all language-server tests pass OK on Windows.