Fix #5083: Disallow using trait parameters as prefix for its parents #5108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents The rationale is to ensure outer-related NPE never happen in Scala. Otherwise, outer NPE may happen, see tests/neg/i5083.scala
odersky
reviewed
Sep 18, 2018
| @@ -960,7 +976,7 @@ class RefChecks extends MiniPhase { thisPhase => | |||
| override def transformTemplate(tree: Template)(implicit ctx: Context) = try { | |||
| val cls = ctx.owner | |||
| checkOverloadedRestrictions(cls) | |||
| checkParents(cls) | |||
| checkParents(cls, tree) | |||
There was a problem hiding this comment.
I'd use two different methods for checking parents:
checkParent(cls)
if (cls.is(Trait)) tree.parents.foreach(checkParentPrefix(cls, _))
That way the logic of checkParents can be left unchanged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5083: Disallow using trait parameters as prefix for its parents
The rationale is to ensure outer-related NPE never happen in Scala.
Otherwise, outer NPE may happen, see tests/neg/i5083.scala