Skip to content

Fix #5090: Fix condition in erasedResult type #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2018
Merged

Fix #5090: Fix condition in erasedResult type #5091

merged 2 commits into from
Sep 9, 2018

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Sep 9, 2018

No description provided.

@odersky odersky requested a review from allanrenucci September 9, 2018 08:11
@allanrenucci
Add byte code test:
98396ad 
Test that T[Int] erases to Int where type T[X] = X
allanrenucci
allanrenucci approved these changes Sep 9, 2018
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have added a byte code test that makes sure we don't box primitive as we used to

@allanrenucci allanrenucci merged commit f5a6b74 into scala:master Sep 9, 2018
@allanrenucci allanrenucci deleted the fix-#5090 branch September 9, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci approved these changes

Assignees

@allanrenucci allanrenucci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @allanrenucci