Skip to content

Typer fixes #5017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Typer fixes #5017

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d30429f
Fix #5008: forbid enums extending enums
Blaisorblade Aug 25, 2018
ca4481a
Fix #5010: check type parents have type arguments
Blaisorblade Aug 25, 2018
dce826f
Simplify fix for #5008
Blaisorblade Aug 25, 2018
4c92bf1
Update error markers
Blaisorblade Aug 25, 2018
1fe1232
Reallow ill-kinded but JavaDefined parents (#5010)
Blaisorblade Aug 25, 2018
40c329b
Revert "Reallow ill-kinded but JavaDefined parents (#5010)"
Blaisorblade Aug 26, 2018
e1dd71e
Fix #5007 (aka scala/bug#5063)
Blaisorblade Aug 26, 2018
8f613a0
Improve robustness of Namer for #5004
Blaisorblade Aug 26, 2018
6cc105c
Fix #5006
Blaisorblade Aug 26, 2018
b0db544
Delete dead code
Blaisorblade Aug 26, 2018
591ccc0
Cleanup
Blaisorblade Aug 26, 2018
7ea018d
Clarify "not found" error
Blaisorblade Aug 27, 2018
998ece9
Remove redundant code
Blaisorblade Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/src/dotty/tools/dotc/typer/Typer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1529,6 +1529,7 @@ class Typer extends Namer
ctx.error(i"$psym is extended twice", tree.pos)
seenParents += psym
if (tree.isType) {
checkSimpleKinded(result) // Not needed for constructor calls, as type arguments will be inferred.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will they be inferred? I'm unconvinced that

class Siz[T](i: Int)
class Zle extends Siz(1)

and

class Siz[T]
class Zle extends Siz

should be treated differently w/r/t superclass targs.

if (psym.is(Trait) && !cls.is(Trait) && !cls.superClass.isSubClass(psym))
result = maybeCall(result, psym, psym.primaryConstructor.info)
}
Expand Down
1 change: 1 addition & 0 deletions tests/neg/i5010.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
class i0 extends Function0 // error