Fix #3539: Add regression tests #4958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
approved these changes
Aug 17, 2018
tests/pos/i3539c.scala
Outdated
| @@ -0,0 +1,3 @@ | |||
| class Test { | |||
| asInstanceOf.asInstanceOf[AnyRef => String].apply(null) | |||
There was a problem hiding this comment.
There is a typo in the original issue. I meant to write:
asInstanceOf[Nothing].asInstanceOf[AnyRef => String].apply(null)There was a problem hiding this comment.
Changed and squashed in one file
nicolasstucki
force-pushed
the
fix-#3539
branch
from
d105229 to
05cd85b
Compare
tests/run/i3539.scala
Outdated
| @@ -1,7 +1,7 @@ | |||
| object Test { | |||
| def main(args: Array[String]): Unit = { | |||
| val i2s = (x: Int) => "" | |||
| assert(asInstanceOf.asInstanceOf[AnyRef => String].apply(null) == "") | |||
| assert(i2s.asInstanceOf.asInstanceOf[AnyRef => String].apply(null) == "") | |||
There was a problem hiding this comment.
But the original compilation failure was (asInstanceOf.asInstanceOf[AnyRef => String].apply(null) == "") — testing results shouldn't mean dropping regressions tests.
There was a problem hiding this comment.
That test would clearly fail at runtime. But the same test is bellow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.