Fix #4929: allow reusing TastyFileManager #4930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvican
approved these changes
Aug 11, 2018
allanrenucci
approved these changes
Aug 11, 2018
| @@ -20,7 +20,14 @@ import scala.collection.mutable | |||
| * temporary directory as class files. | |||
| */ | |||
| final class TastyFileManager extends ClassFileManager { | |||
| private[this] val tempDir = Files.createTempDirectory("backup").toFile | |||
| private[this] def newTempDir() = Files.createTempDirectory("backup").toFile | |||
There was a problem hiding this comment.
This could be inlined in def tempDir
Recreate `tempDir` if we're reused after `complete` was called and deleted the existing `tempDir`. The output in scala#4929 was produced by this commit.
That was only for history, not to be left in the actual plugin.
Blaisorblade
force-pushed
the
fix-sbt-tastyfilemanager
branch
from
f0b2892 to
0d4dc18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4929.