-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix misspelled words in comments and error messages #4926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and LGTM apart from these two typos!
Did you use some tool to spell-check this? Can you share how you did it?
@@ -626,7 +626,7 @@ class DottyBackendInterface(outputDirectory: AbstractFile, val superCallsMap: Ma | |||
|
|||
def symbol: Symbol = a.tree.symbol | |||
|
|||
def args: List[Tree] = List.empty // those arguments to scala-defined annotations. they are never emmited | |||
def args: List[Tree] = List.empty // those arguments to scala-defined annotations. they are never emmitted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s emitted, one m
@@ -274,7 +274,7 @@ object TastyFormat { | |||
|
|||
final val OBJECTCLASS = 23 // The name of an object class (or: module class) `<name>$`. | |||
|
|||
final val SIGNED = 63 // A pair of a name and a signature, used to idenitfy | |||
final val SIGNED = 63 // A pair of a name and a signature, used to idenitify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identify
Merged right away to prevent conflicts, could you please do the fixups in a new PR and tag me for review? Thanks again! |
@Blaisorblade I used https://github.com/client9/misspell for the detection. The tool is very helpful. Also, sorry for the miscorrection. Thanks for merging it! |
Thank you! I'm fixing the followups myself in #4931. |
This pull request fixes several minor typos found in comments and error messages.