Skip to content

Fix misspelled words in comments and error messages #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Aug 10, 2018

This pull request fixes several minor typos found in comments and error messages.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and LGTM apart from these two typos!
Did you use some tool to spell-check this? Can you share how you did it?

@@ -626,7 +626,7 @@ class DottyBackendInterface(outputDirectory: AbstractFile, val superCallsMap: Ma

def symbol: Symbol = a.tree.symbol

def args: List[Tree] = List.empty // those arguments to scala-defined annotations. they are never emmited
def args: List[Tree] = List.empty // those arguments to scala-defined annotations. they are never emmitted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s emitted, one m

@@ -274,7 +274,7 @@ object TastyFormat {

final val OBJECTCLASS = 23 // The name of an object class (or: module class) `<name>$`.

final val SIGNED = 63 // A pair of a name and a signature, used to idenitfy
final val SIGNED = 63 // A pair of a name and a signature, used to idenitify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identify

@Blaisorblade Blaisorblade merged commit 3bf8a16 into scala:master Aug 10, 2018
@Blaisorblade
Copy link
Contributor

Merged right away to prevent conflicts, could you please do the fixups in a new PR and tag me for review? Thanks again!

@seratch
Copy link
Contributor Author

seratch commented Aug 11, 2018

@Blaisorblade I used https://github.com/client9/misspell for the detection. The tool is very helpful. Also, sorry for the miscorrection. Thanks for merging it!

@seratch seratch deleted the fix-typo branch August 11, 2018 01:40
Blaisorblade added a commit to dotty-staging/dotty that referenced this pull request Aug 11, 2018
Blaisorblade added a commit to dotty-staging/dotty that referenced this pull request Aug 11, 2018
@Blaisorblade
Copy link
Contributor

Thank you! I'm fixing the followups myself in #4931.

nicolasstucki added a commit that referenced this pull request Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants