Fixes to transparent functions #4881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
fix-transparent-1
branch
from
90707d5 to
9abda15
Compare
nicolasstucki
approved these changes
Aug 2, 2018
| case Some(x) => x > 1 || x == 1 && !boundSym.is(Method) | ||
| case none => true | ||
| } | ||
| } && !boundSym.is(TransparentImplicitMethod) |
There was a problem hiding this comment.
it would be clearer and more performant if the conditions are inverted
!boundSym.is(TransparentImplicitMethod) &&
refCount.get(boundSym) match {
...There was a problem hiding this comment.
I doubt the "more performant part" since the test isboundSym.is(TransparentImplicitMethod) is ~99% likely to succeed. So it's better to put the test first that prunes more cases.
When adding implicit bindings to an implicit context of an inline body, we need to maintain the transparency of the implicits. The added implicit bindings are eliminated after inlining, since they are either unused or have been inlined.
If the result of reducing a projection has local bindings, these bindings need to be copied. Test case in run/Tuple.scala
Can't lift bindings from arguments as this might change evaluation order and it also does not work for cbn parameters. Also, fix stray printing
odersky
force-pushed
the
fix-transparent-1
branch
5 times, most recently
from
4b83e2e to
8b941d6
Compare
|
I have put previously pushed subsequent commits in a separate PR, so that we can merge what was already approved. |
nicolasstucki
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end-goal is to have a nice implementation of tuples/hlists. A start is in Tuple.scala. This stresses transparent handling in interesting ways.