-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix inline scripted #4857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inline scripted #4857
Conversation
@nicolasstucki Can you have a look.
|
Setting prio:blocker because this is preventing the nightly builds from being published. |
The issue seems to be that in the third @smarter where is the logic in that takes care of emitted classfiles? |
80cab81
to
b6e92ce
Compare
8be6a33
to
0e43a90
Compare
With the introduction of transparent, an implicit conversion from Double to Int kicked in. We change the type to String to prevent this
We cannot delegate to the default class file manager. In some situations, when an incremental compilation fails, we need to restore tasty files from previous compilation. These tasty files must be backed up in a tmp directory which is different from the one of the default class file manager.
0e43a90
to
59a3b85
Compare
Scripted tests pass at http://dotty-ci.epfl.ch/lampepfl/dotty/6640 |
The change to the class file manager seems to cause over compilation in some cases. It is better than having tasty files and class files out of sync
712a52a
to
40c76d2
Compare
I'll look into the newly failing test |
With the introduction of transparent, an implicit conversion from Double
to Int kicked in. We change the type to String to prevent this